fix: make mutations correctly invalidate queries - #1216
Merged
Conversation
Pascal-Delange
left a comment
Pascal-Delange
left a comment
Contributor
There was a problem hiding this comment.
I don't have specific questions on the code directly, just a sanity check perhaps: did you make sure that it does not reset filters and pagination state when we do a batch action in the inbox ?
Contributor
Author
Filters and pagination states are parameters for a query. Query invalidations clear the cache stored for a query. So invalidating query cannot reset filters and pagination states, only the displayed results. |
ChibiBlasphem
deleted the
fix/correctly-invalidate-queries-on-mutation
branch
November 24, 2025 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR to naively and manually invalidate queries to avoid stale data being kept in the app.
A further PR will add conventions on query caching strategy and a more streamlined way of invalidating related queries
Note
Standardizes React Query keys to
casesand adds onSuccess invalidation to refresh cases data after mutations.['case', ...]to['cases', ...]across mutations anduseCreateKycEnrichmentQuery.useQueryClientandonSuccesshandlers to invalidate['cases']after mutations in:useAddCommentMutation,useAddRuleSnoozeMutation,useAddToCaseMutation,useCloseCaseMutation,useCreateCaseMutation,useEditAssigneeMutation,useEditInboxMutation,useEditNameMutation,useEditSuspicionMutation,useEditTagsMutation,useEscalateCaseMutation,useMassUpdateCasesMutation,useOpenCaseMutation,useSnoozeCaseMutation.Written by Cursor Bugbot for commit 6c81eca. This will update automatically on new commits. Configure here.